[cfe-commits] [patch] Tracking simple arithmetic constraints (PR2695)

[Zhongxing Xu]

On Fri, Jun 18, 2010 at 1:28 PM, Jordy Rose <jediknil at belkadan.com> wrote:

> On Thu, 17 Jun 2010 09:50:43 +0800, Zhongxing Xu <xuzhongxing at gmail.com>
> wrote:
> > I agree this patch should go in. It's great job. I haven't verified the
> > trick in  RangeConstraintManager::AssumeSymLT. It's not straightforward
> to
> > get it. But I believe it's right. Maybe some comments are helpful.
>
> Well, I made one last set of simplifications, by making
> RangeSet::Intersect() handle wraparound ranges instead of worrying about
> that in the AssumeSym*() methods. The AssumeSym*() methods look /much/ more
> similar now, and are much easier to understand. Here's what that looks
> like.
>
> If and when we do switch to a generic Transformer, I'd be glad to help
> work on fitting it in to the SimpleConstraintManagers.
>
> I'll check this in soon, then?


This patch looks cleaner, especially the wrap-around processing part. Great
work, Jordy!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100618/b207f134/attachment.html>