[cfe-commits] r106139 - /cfe/trunk/lib/Sema/SemaExprObjC.cpp

[Fariborz Jahanian]

Author: fjahanian
Date: Wed Jun 16 14:56:08 2010
New Revision: 106139

URL: http://llvm.org/viewvc/llvm-project?rev=106139&view=rev
Log:
C return types must be complete as well.
Moved check before we build the ObjCMessageExpr node.
(PR7386 related).


Modified:
    cfe/trunk/lib/Sema/SemaExprObjC.cpp

Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprObjC.cpp?rev=106139&r1=106138&r2=106139&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExprObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExprObjC.cpp Wed Jun 16 14:56:08 2010
@@ -1007,6 +1007,12 @@
   if (CheckMessageArgumentTypes(Args, NumArgs, Sel, Method, false,
                                 LBracLoc, RBracLoc, ReturnType))
     return ExprError();
+  
+  if (!ReturnType->isVoidType()) {
+    if (RequireCompleteType(LBracLoc, ReturnType, 
+                            diag::err_illegal_message_expr_incomplete_type))
+      return ExprError();
+  }
 
   // Construct the appropriate ObjCMessageExpr instance.
   Expr *Result;
@@ -1018,11 +1024,6 @@
   else
     Result = ObjCMessageExpr::Create(Context, ReturnType, LBracLoc, Receiver, 
                                      Sel, Method, Args, NumArgs, RBracLoc);
-  if (Context.getLangOptions().CPlusPlus && !ReturnType->isVoidType()) {
-    if (RequireCompleteType(LBracLoc, ReturnType, 
-                      diag::err_illegal_message_expr_incomplete_type))
-      return ExprError();
-    }
   return MaybeBindToTemporary(Result);
 }