[cfe-commits] [PATCH v3] Break Frontend's dependency on Rewrite, Checker and CodeGen in shared library configuration

[Daniel Dunbar]

Hi Peter,

Thanks, this seems like a good improvement.

In the long term, I'm not totally sure we want those libs to have
dependencies on Frontend, but for now it seems like the best approach.

Can you regenerate the patch? It doesn't apply (git am) cleanly for me.

 - Daniel

On Sat, Jun 12, 2010 at 4:42 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> Currently, all AST consumers are located in the Frontend library,
> meaning that in a shared library configuration, Frontend has a
> dependency on Rewrite, Checker and CodeGen.  This is suboptimal for
> clients which only wish to make use of the frontend.  CodeGen in
> particular introduces a large number of unwanted dependencies.
>
> This patch breaks the dependency by moving all AST consumers with
> dependencies on Rewrite, Checker and/or CodeGen to their respective
> libraries.  The patch therefore introduces dependencies in the other
> direction (i.e. from Rewrite, Checker and CodeGen to Frontend).
>
> After applying this patch, Clang builds correctly using CMake and
> shared libraries ("cmake -DBUILD_SHARED_LIBS=ON").
>
> N.B. This patch includes file renames which are indicated in the
> patch body.
>
> Changes in this revision of the patch:
>  - Fixed some copy-paste mistakes in the header files
>  - Modified certain aspects of the coding to comply with the LLVM
>   Coding Standards
>
> Thanks,
> --
> Peter
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>