[cfe-commits] [PATCH] Add an option to limit the number of overload candidates printed (issue1591041)

[chandlerc at gmail.com]

Just a few tweaks I think, and looks good to me. Probably good for
post-commit review for anything else.


http://codereview.appspot.com/1591041/diff/8001/3006
File include/clang/Basic/Diagnostic.h (right):

http://codereview.appspot.com/1591041/diff/8001/3006#newcode179
include/clang/Basic/Diagnostic.h:179:
Doc for the enum proper?

http://codereview.appspot.com/1591041/diff/8001/3006#newcode328
include/clang/Basic/Diagnostic.h:328: /// default, we omit candidates
when they're spammy.
Is this comment about the default still accurate? Also, do we want to
specify the default here, or with the flag's docs?

http://codereview.appspot.com/1591041/diff/8001/3004
File include/clang/Frontend/DiagnosticOptions.h (right):

http://codereview.appspot.com/1591041/diff/8001/3004#newcode39
include/clang/Frontend/DiagnosticOptions.h:39: ///
Diagnostic::OverloadsShown
Is one bit always going to be enough then?

http://codereview.appspot.com/1591041/diff/8001/3012
File lib/Sema/SemaOverload.cpp (right):

http://codereview.appspot.com/1591041/diff/8001/3012#newcode5708
lib/Sema/SemaOverload.cpp:5708: "Condition when adding candidates should
have prevented this");
This shouldn't refer to the other code, but just the invariant imo:
"Non-viable builtin operators are not added to our reported set." or
some such...

http://codereview.appspot.com/1591041/show