[cfe-commits] [patch] Catch a few simple misuses of free()

[Ted Kremenek]

On Jun 5, 2010, at 5:56 PM, Jordy Rose wrote:

> 
> On Fri, 4 Jun 2010 23:35:39 -0700, Ted Kremenek <kremenek at apple.com>
> wrote:
>> On Jun 4, 2010, at 10:48 PM, Jordy Rose wrote:
>>> I'm a little worried that the messages are a bit long now.
>> 
>> I personally think the new diagnostics are awesome, but I'm thinking
> more
>> about how they would be presented in scan-build output or an IDE rather
>> than just the command line.  If you feel that they are too long, please
>> feel free to shorten them.  I really love how they are very precise and
>> clear.
> 
> I did check it in scan-build, and it does look a lot better, so I guess
> it's good. The messages are really not as helpful without knowing what the
> offending values are.
> 
>> Minor nit:
>> 
>> I'd include the name of the variable in quotes or some other way to
>> distinguish it as a "name", e.g.:
> 
> Fixed!
> 
> I'll go ahead and commit it tonight, unless there are any last comments.

Go ahead.  It looks great!