[cfe-commits] [patch] Implement __clear_cache on ARM

Rafael Espindola espindola at google.com
Fri Jun 4 22:44:15 PDT 2010


> I think you can use "f" without specifying a header name, but I'm
> guessing you don't want the warning asking for an explicit declaration
> of __clear_cache?  (I don't have an ARM gcc around to check how it
> behaves.)

Exactly, the issue is the warning. GCC handles this as a fully magic
function, no declaration in a header is needed.

>> The patch also removes some dead code. There is not need to special
>> case ARM::BI__builtin_thread_pointer since the generic intrinsic
>> handling code takes care of it.
>
> Patch looks fine.

Sorry, would you mind reviewing the new version attached? Trying to
bootstrap clang I noticed that the name was being mangle in c++ :-(

If you think the assert should stay, I can also make
GetOrCreateLLVMFunction public.

> -Eli
>

Thanks,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clear_cache.patch
Type: application/octet-stream
Size: 2057 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100605/7871e1bd/attachment.obj>


More information about the cfe-commits mailing list