[cfe-commits] [libcxx] r104982 - /libcxx/trunk/include/cstddef

Howard Hinnant hhinnant at apple.com
Wed Jun 2 11:45:42 PDT 2010


On May 28, 2010, at 5:10 PM, Sean Hunt wrote:

> On 05/28/2010 02:12 PM, Howard Hinnant wrote:
>> <chuckle>  I know, I know.  On Mac OS the first trip through<stddef.h>  doesn't define offsetof.  Or said differently, offsetof doesn't get defined if any of __need_* are defined.  The first trip creates the desired macros and #undefines the request.  The second trip creates offsetof.<shrug>
>> 
>> -Howard
> 
> Could a comment be included to that effect so that someone doesn't just 
> go and remove it because they saw a redundant include?

Instead of a comment I've reverted the Ubuntu porting changes.  These changes should go under a #ifdef and that #ifdef can be commented.

-Howard





More information about the cfe-commits mailing list