[cfe-commits] r105301 - /cfe/trunk/lib/CodeGen/CGVTables.cpp

[Anders Carlsson]

Author: andersca
Date: Tue Jun  1 18:52:26 2010
New Revision: 105301

URL: http://llvm.org/viewvc/llvm-project?rev=105301&view=rev
Log:
More cleanup.

Modified:
    cfe/trunk/lib/CodeGen/CGVTables.cpp

Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGVTables.cpp?rev=105301&r1=105300&r2=105301&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGVTables.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGVTables.cpp Tue Jun  1 18:52:26 2010
@@ -87,12 +87,11 @@
   /// MostDerivedClassLayout - the AST record layout of the most derived class.
   const ASTRecordLayout &MostDerivedClassLayout;
 
-  /// BaseSubobjectMethodPairTy - Uniquely identifies a member function
+  /// MethodBaseOffsetPairTy - Uniquely identifies a member function
   /// in a base subobject.
-  typedef std::pair<BaseSubobject, const CXXMethodDecl *>
-    BaseSubobjectMethodPairTy;
-  
-  typedef llvm::DenseMap<BaseSubobjectMethodPairTy,
+  typedef std::pair<const CXXMethodDecl *, uint64_t> MethodBaseOffsetPairTy;
+
+  typedef llvm::DenseMap<MethodBaseOffsetPairTy,
                          OverriderInfo> OverridersMapTy;
   
   /// OverridersMap - The final overriders for all virtual member functions of 
@@ -160,11 +159,10 @@
   /// the subobject with the given base offset. 
   OverriderInfo getOverrider(const CXXMethodDecl *MD, 
                              uint64_t BaseOffset) const {
-    BaseSubobject Base(MD->getParent(), BaseOffset);
-    assert(OverridersMap.count(std::make_pair(Base, MD)) && 
+    assert(OverridersMap.count(std::make_pair(MD, BaseOffset)) && 
            "Did not find overrider!");
     
-    return OverridersMap.lookup(std::make_pair(Base, MD));
+    return OverridersMap.lookup(std::make_pair(MD, BaseOffset));
   }
   
   /// dump - dump the final overriders.
@@ -231,7 +229,8 @@
     PropagateOverrider(MD, OffsetInLayoutClass, MD, Offsets);
 
     // Add the overrider as the final overrider of itself.
-    OverriderInfo& Overrider = OverridersMap[std::make_pair(Base, MD)];
+    OverriderInfo& Overrider = 
+      OverridersMap[std::make_pair(MD, Base.getBaseOffset())];
     assert(!Overrider.Method && "Overrider should not exist yet!");
 
     Overrider.Offset = OffsetInLayoutClass;
@@ -373,11 +372,8 @@
     for (unsigned I = 0, E = OffsetVector.size(); I != E; ++I) {
       uint64_t Offset = OffsetVector[I];
 
-      BaseSubobject OverriddenSubobject = BaseSubobject(OverriddenRD, Offset);
-      BaseSubobjectMethodPairTy SubobjectAndMethod =
-        std::make_pair(OverriddenSubobject, OverriddenMD);
-      
-      OverriderInfo &Overrider = OverridersMap[SubobjectAndMethod];
+      MethodBaseOffsetPairTy MethodAndBaseOffset(OverriddenMD, Offset);
+      OverriderInfo &Overrider = OverridersMap[MethodAndBaseOffset];
 
       assert(Overrider.Method && "Did not find existing overrider!");