[cfe-commits] r105218 - /cfe/trunk/lib/CodeGen/Mangle.h

Charles Davis cdavis at mymail.mines.edu
Mon May 31 10:04:35 PDT 2010

On 5/31/10 2:27 AM, Chandler Carruth wrote:
> Author: chandlerc
> Date: Mon May 31 03:27:42 2010
> New Revision: 105218
> URL: http://llvm.org/viewvc/llvm-project?rev=105218&view=rev
> Log:
> Silence GCC warning about an accessible non-virtual destructor in a class with
> virtual methods.
> Please review cdavis, should these methods even be virtual?
When I wrote that patch, I was thinking, "I want to override those
methods in the other manglers, because this is the public interface to
the mangler." So I (prematurely) made the methods virtual.

I probably shouldn't have made those methods virtual just yet. I don't
even have another mangler ready yet (still working on it). I'll change
the methods back for now.


More information about the cfe-commits mailing list