[cfe-commits] [Request for approval] Added basic source locations to Elaborated and DependentName types.

[John McCall]

On May 19, 2010, at 3:50 AM, Abramo Bagnara wrote:

> Il 19/05/2010 01:29, John McCall ha scritto:
>> 
>>>> 
>>>> I notice that you didn't include the SourceRange for the NestedNameSpecifiers
>>>> like I asked.  Without this, your calculation of the source ranges for these
>>>> TypeLocs is incorrect, particularly because you're consistently assuming that
>>>> KeywordLoc is a real source location — it's meaningless for ETK_None,
>>>> which is possible for both ElaboratedType and DependentNameType.
>>>> 
>>>> Please fix this.
>>> 
>>> After some pain to fix some obscure details, we have revised the
>>> reverted patch to add NestedNameSpecifiers location ranges and to fix
>>> failures due to missing compilation of TemplateArgLocInfo.
>>> 
>>> Please review the attached patch.
>> 
>> Looks good!  I only have two complaints.
> 
> I've attached the revised patch.
> <ElabTypeLoc-2.patch>

Approved, thanks!

John.