[cfe-commits] [Request for approval] Added basic source locations to Elaborated and DependentName types.

[Abramo Bagnara]

Il 14/05/2010 19:48, John McCall ha scritto:
> 
> On May 14, 2010, at 7:55 AM, Abramo Bagnara wrote:
> 
>> Il 13/05/2010 22:43, John McCall ha scritto:
>>> On May 13, 2010, at 2:09 AM, Abramo Bagnara wrote:
>>>> The attached patch improves support for locations inside Elaborated
>>>> and DependentName types.
>>
>> I've committed the fixed patch in r103770.
> 
> I notice that you didn't include the SourceRange for the NestedNameSpecifiers
> like I asked.  Without this, your calculation of the source ranges for these
> TypeLocs is incorrect, particularly because you're consistently assuming that
> KeywordLoc is a real source location — it's meaningless for ETK_None,
> which is possible for both ElaboratedType and DependentNameType.
> 
> Please fix this.

After some pain to fix some obscure details, we have revised the
reverted patch to add NestedNameSpecifiers location ranges and to fix
failures due to missing compilation of TemplateArgLocInfo.

Please review the attached patch.

It passes all the tests and self hosting.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ElabTypeLoc.patch
Type: text/x-patch
Size: 27512 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100518/26e4c0da/attachment.bin>