[cfe-commits] [Request for approval] Merge Elaborated and QualifiedName types

[Abramo Bagnara]

Il 11/05/2010 23:02, John McCall ha scritto:
> 
> On May 11, 2010, at 1:41 PM, Abramo Bagnara wrote:
> 
> +public:
> +  virtual ~TypeWithKeyword() {} // pin vtable to Type.cpp
> +
> 
> To actually pin this to a file you have to declare in the class and define it out-of-line in the file.
> 
>      /// refers to a member of the current instantiation, and then
> -    /// type-checking and building a QualifiedNameType (when possible).
> -    QualType TransformDependentNameType(TypeLocBuilder &TLB, DependentNameTypeLoc TL, 
> -                                   QualType ObjectType);
> +    /// type-checking and building a ElaboratedType (when possible).
> +    QualType TransformDependentNameType(TypeLocBuilder &TLB,
> +                                        DependentNameTypeLoc TL,
> +                                        QualType ObjectType);
>    };
>  }
>  
> @@ -5413,7 +5397,7 @@
>      Result = QualType(T, 0);
>  
>    // Rebuild the typename type, which will probably turn into a
> -  // QualifiedNameType.
> +  // ElaboratedType.
>    else if (const TemplateSpecializationType *TemplateId = T->getTemplateId()) {
>      QualType NewTemplateId
>        = TransformType(QualType(TemplateId, 0));
> @@ -5462,7 +5446,7 @@
>  /// Here, the type "typename X<T>::pointer" will be created as a DependentNameType,
>  /// since we do not know that we can look into X<T> when we parsed the type.
>  /// This function will rebuild the type, performing the lookup of "pointer"
> -/// in X<T> and returning a QualifiedNameType whose canonical type is the same
> +/// in X<T> and returning a ElaboratedType whose canonical type is the same
>  /// as the canonical type of T*, allowing the return types of the out-of-line
> 
> All of these should read "an ElaboratedType".  Please audit the rest of your comment changes for this, I know there are other places.
> 
> Otherwise, looks great!

Thanks for reviewing. I've attached the revised version. Of course it
passes all the tests.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: MergeElaboratedAndQualifiedName-2.patch
Type: text/x-patch
Size: 83820 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100511/408fbef6/attachment.bin>