[cfe-commits] r102833 - in /cfe/trunk/lib/CodeGen: CGCall.cpp CGObjCGNU.cpp CodeGenFunction.h

[David Chisnall]

On 1 May 2010, at 19:10, Chris Lattner wrote:

> 
> On May 1, 2010, at 4:15 AM, David Chisnall wrote:
> 
>> Author: theraven
>> Date: Sat May  1 06:15:56 2010
>> New Revision: 102833
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=102833&view=rev
>> Log:
>> Tweaked EmitCall() to permit the caller to provide some metadata to attach to the call site.
>> 
>> Used this in CGObjCGNU to attach metadata about message sends to permit speculative inlining.
> 
> Would it make sense to return the created Instruction* by reference, and let the client install the metadata?  If the client wanted to install multiple pieces of metadata or do other things with the call, this would be a more natural interface.  I think this would also simplify some debug info stuff.

There's not much in it from my perspective.  I'm happy to rewrite it to use the other approach if you prefer.

David