[cfe-commits] [Request for approval] Wrong extern inside no braces linkage specification declaration

Sebastian Redl sebastian.redl at getdesigned.at
Wed Apr 28 05:13:10 PDT 2010

On Wed, 28 Apr 2010 11:58:20 +0200, Abramo Bagnara
<abramo.bagnara at gmail.com> wrote:
> Currently clang marks these two declarations
> extern "C" int a;
> extern "C" void foo();
> as extern in StorageClassAsWritten, but the inner declarations does not
> have any storage class specified (and C++ standard does not allow any).
> The attached patch wrt r102259 fixes the problem (and do not introduce
> any regressions).
> This patch has already been sent to cfe-dev, currently without pending
> objections but without explicit approval.
> http://lists.cs.uiuc.edu/pipermail/cfe-dev/2010-April/008773.html
> Having just obtained write access, is it ok if I commit it in?

That was a misunderstanding, not an objection. The patch looks fine to me.


More information about the cfe-commits mailing list