[cfe-commits] r102222 - in /cfe/trunk: include/clang/Parse/Action.h lib/Parse/ParseObjc.cpp lib/Sema/Sema.h lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclObjC.cpp

[Douglas Gregor]

On Apr 23, 2010, at 5:53 PM, John McCall wrote:

> 
> On Apr 23, 2010, at 4:01 PM, Douglas Gregor wrote:
> 
>> Author: dgregor
>> Date: Fri Apr 23 18:01:43 2010
>> New Revision: 102222
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=102222&view=rev
>> Log:
>> Rework Parser-Sema interface for Objective-C @catch exception object
>> arguments. Rather than having the parser call ActOnParamDeclarator
>> (which is a bit of a hack), call a new ActOnObjCExceptionDecl
>> action. We'll be moving more functionality into this handler to
>> perform earlier checking of @catch.
>> 
>> Modified:
>>   cfe/trunk/include/clang/Parse/Action.h
>>   cfe/trunk/lib/Parse/ParseObjc.cpp
>>   cfe/trunk/lib/Sema/Sema.h
>>   cfe/trunk/lib/Sema/SemaDecl.cpp
>>   cfe/trunk/lib/Sema/SemaDeclObjC.cpp
>> 
>> Modified: cfe/trunk/include/clang/Parse/Action.h
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Parse/Action.h?rev=102222&r1=102221&r2=102222&view=diff
>> ==============================================================================
>> --- cfe/trunk/include/clang/Parse/Action.h (original)
>> +++ cfe/trunk/include/clang/Parse/Action.h Fri Apr 23 18:01:43 2010
>> @@ -468,7 +468,11 @@
>>  virtual DeclPtrTy ActOnParamDeclarator(Scope *S, Declarator &D) {
>>    return DeclPtrTy();
>>  }
>> -  virtual void ActOnObjCCatchParam(DeclPtrTy D) {
>> +
>> +  /// \brief Parsed an exception object declaration within an Objective-C
>> +  /// @catch statement.
>> +  virtual DeclPtrTy ActOnObjCExceptionDecl(Scope *S, Declarator &D) {
>> +    return DeclPtrTy();
>>  }
>> 
>>  /// AddInitializerToDecl - This action is called immediately after
>> 
> 
> There's an obligatory change to PrintParserCallbacks for this.


Good catch. Looks like Benjamin Kramer fixed it in r 102241; thanks!

	- Doug