[cfe-commits] r102112 - in /cfe/trunk: include/clang/Basic/LangOptions.h include/clang/Driver/CC1Options.td lib/CodeGen/CGObjCMac.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/Frontend/CompilerInvocation.cpp

[Fariborz Jahanian]

On Apr 22, 2010, at 1:35 PM, Douglas Gregor wrote:

>
> On Apr 22, 2010, at 1:26 PM, Fariborz Jahanian wrote:
>
>> Author: fjahanian
>> Date: Thu Apr 22 15:26:39 2010
>> New Revision: 102112
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=102112&view=rev
>> Log:
>> Support for -fno-constant-cfstrings option - wip.
>>
>>
>> Modified:
>>   cfe/trunk/include/clang/Basic/LangOptions.h
>>   cfe/trunk/include/clang/Driver/CC1Options.td
>>   cfe/trunk/lib/CodeGen/CGObjCMac.cpp
>>   cfe/trunk/lib/CodeGen/CodeGenModule.cpp
>>   cfe/trunk/lib/CodeGen/CodeGenModule.h
>>   cfe/trunk/lib/Frontend/CompilerInvocation.cpp
>>
>> Modified: cfe/trunk/include/clang/Basic/LangOptions.h
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/LangOptions.h?rev=102112&r1=102111&r2=102112&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- cfe/trunk/include/clang/Basic/LangOptions.h (original)
>> +++ cfe/trunk/include/clang/Basic/LangOptions.h Thu Apr 22 15:26:39  
>> 2010
>> @@ -101,6 +101,7 @@
>>  unsigned CatchUndefined    : 1; // Generate code to check for  
>> undefined ops.
>>  unsigned DumpRecordLayouts : 1; /// Dump the layout of IRgen'd  
>> records.
>>  unsigned DumpVTableLayouts : 1; /// Dump the layouts of emitted  
>> vtables.
>> +  unsigned NoConstantCFStrings : 1;  // Do not do CF strings
>>
>>  // FIXME: This is just a temporary option, for testing purposes.
>>  unsigned NoBitFieldTypeAlign : 1;
>> @@ -134,6 +135,7 @@
>>    GNUMode = GNUKeywords = ImplicitInt = Digraphs = 0;
>>    HexFloats = 0;
>>    GC = ObjC1 = ObjC2 = ObjCNonFragileABI = ObjCNonFragileABI2 = 0;
>> +    NoConstantCFStrings = 0;
>>    C99 = Microsoft = CPlusPlus = CPlusPlus0x = 0;
>>    CXXOperatorNames = PascalStrings = WritableStrings =  
>> ConstStrings = 0;
>>    Exceptions = SjLjExceptions = Freestanding = NoBuiltin = 0;
>
> Does -fno-constant-cfstrings affect semantic analysis in any way? If  
> so, then this bit needs to be serialized to PCH and checked when we  
> load a PCH file. If not, then it should be part of code-generation  
> options rather than part of LangOptions.

Yes, there will be a minor semantics checking done later. Done in    
r102130

- Fariborz

>
>
>> Modified: cfe/trunk/include/clang/Driver/CC1Options.td
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=102112&r1=102111&r2=102112&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>>