[cfe-commits] r101838 - in /cfe/trunk: lib/Sema/Sema.h test/SemaCXX/warn-unused-parameters.cpp

[Douglas Gregor]

Author: dgregor
Date: Mon Apr 19 18:56:20 2010
New Revision: 101838

URL: http://llvm.org/viewvc/llvm-project?rev=101838&view=rev
Log:
Do not diagnose unused-parameter errors in template instantiations. We
will already have done so when the template is declared.

Added:
    cfe/trunk/test/SemaCXX/warn-unused-parameters.cpp
Modified:
    cfe/trunk/lib/Sema/Sema.h

Modified: cfe/trunk/lib/Sema/Sema.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema.h?rev=101838&r1=101837&r2=101838&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/Sema.h (original)
+++ cfe/trunk/lib/Sema/Sema.h Mon Apr 19 18:56:20 2010
@@ -853,12 +853,18 @@
     if (Diags.getDiagnosticLevel(diag::warn_unused_parameter) == 
           Diagnostic::Ignored)
       return;
+
+    // Don't diagnose unused-parameter errors in template instantiations; we
+    // will already have done so in the template itself.
+    if (!ActiveTemplateInstantiations.empty())
+      return;
     
     for (; Param != ParamEnd; ++Param) {
       if (!(*Param)->isUsed() && (*Param)->getDeclName() &&
-          !(*Param)->template hasAttr<UnusedAttr>())
+          !(*Param)->template hasAttr<UnusedAttr>()) {
         Diag((*Param)->getLocation(), diag::warn_unused_parameter)
           << (*Param)->getDeclName();
+      }
     }
   }
 

Added: cfe/trunk/test/SemaCXX/warn-unused-parameters.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-unused-parameters.cpp?rev=101838&view=auto
==============================================================================
--- cfe/trunk/test/SemaCXX/warn-unused-parameters.cpp (added)
+++ cfe/trunk/test/SemaCXX/warn-unused-parameters.cpp Mon Apr 19 18:56:20 2010
@@ -0,0 +1,26 @@
+// RUN: %clang_cc1 -fsyntax-only -Wunused-parameter -verify %s
+template<typename T>
+struct X {
+  T f0(T x);
+  T f1(T x);
+  T f2(T);
+  template<typename U> U f3(U x);
+  template<typename U> U f4(U x);
+  template<typename U> U f5(U);
+};
+
+template<typename T> T X<T>::f0(T x) { return x; }
+template<typename T> T X<T>::f1(T) { return T(); }
+template<typename T> T X<T>::f2(T x) { return T(); } // expected-warning{{unused parameter 'x'}}
+template<typename T> template<typename U> U X<T>::f3(U x) { return x; }
+template<typename T> template<typename U> U X<T>::f4(U) { return U(); }
+template<typename T> template<typename U> U X<T>::f5(U x) { return U(); } // expected-warning{{unused parameter 'x'}}
+
+void test_X(X<int> &x, int i) {
+  x.f0(i);
+  x.f1(i);
+  x.f2(i);
+  x.f3(i);
+  x.f4(i);
+  x.f5(i);
+}