[cfe-commits] PATCH: Add somewhat hacky support for -fgnu-keywords and -fasm

Chandler Carruth chandlerc at google.com
Sat Apr 17 01:52:18 PDT 2010


On Mon, Apr 5, 2010 at 8:20 AM, Douglas Gregor <dgregor at apple.com> wrote:

>
> On Apr 3, 2010, at 12:58 AM, Chandler Carruth wrote:
>
> > I'm not exactly proud of this, but it works, and makes more sense than
> GCC's options. Basically it makes both '-fasm' and '-fgnu-keywords' (and
> their no- variants) synonyms for explicitly enabling or disabling
> GNU-extension keywords. This is actually the behavior of -fasm in GCC, their
> -fgnu-keywords is a more limited flag. If people see real benefit to
> supporting this distinction I can, but it didn't seem productive. It also
> doesn't make a lot of logical sense.
>
> GCC's behavior really doesn't make any sense, but this seems like a
> reasonable (sane) approximation.
>
> Please update the PCH reader and writer to serialize the GNUKeywords bit.
> Otherwise, looks good!
>

Updated patch attached, thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100417/acaa51ae/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-gnu-keywords.patch
Type: application/octet-stream
Size: 9269 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100417/acaa51ae/attachment.obj>


More information about the cfe-commits mailing list