[cfe-commits] [PATCH] Haiku support

[Chris Lattner]

On Apr 10, 2010, at 5:59 AM, Paul Davey wrote:

> Preliminary support for the haiku operating system as a target.
> A target info for it.
> Also header search paths.
> please review...

This looks basically fine, a couple minor things:

+    X86_32TargetInfo::getTargetDefines(Opts, Builder);
+    Builder.defineMacro("__INTEL__");
+    Builder.defineMacro("__HAIKU__");
+//    Builder.defineMacro("__haiku__");
+  }

Please no commented-out code.

+  case llvm::Triple::Haiku:
+    {
+      AddPath("/boot/develop/abi/x86/gcc4/tools/gcc-4.3.3-haiku-090629/bin/../lib/gcc/i586-pc-haiku/4.3.3/include", System, true, false, false);
+      AddPath("/boot/develop/abi/x86/gcc4/tools/gcc-4.3.3-haiku-090629/bin/../lib/gcc/i586-pc-haiku/4.3.3/include-fixed", System, true, false, false);

Please stay in 80 columns, also you don't need the {}'s

Do you really need to implicitly include all this stuff??
+      AddPath("/boot/common/include", System, true, false, false);
+      AddPath("/boot/develop/headers/os", System, true, false, false);
+      AddPath("/boot/develop/headers/os/app", System, true, false, false);
+      AddPath("/boot/develop/headers/os/app", System, true, false, false);
+      AddPath("/boot/develop/headers/os/device", System, true, false, false);
+      AddPath("/boot/develop/headers/os/drivers", System, true, false, false);
+      AddPath("/boot/develop/headers/os/game", System, true, false, false); 
+      AddPath("/boot/develop/headers/os/interface", System, true, false, false);
+      AddPath("/boot/develop/headers/os/kernel", System, true, false, false);
+      AddPath("/boot/develop/headers/os/locale", System, true, false, false);
+      AddPath("/boot/develop/headers/os/mail", System, true, false, false);
+      AddPath("/boot/develop/headers/os/media", System, true, false, false);
+      AddPath("/boot/develop/headers/os/midi", System, true, false, false);
.....

-Chris