[cfe-commits] r100914 - /cfe/trunk/lib/Basic/SourceManager.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Fri Apr  9 20:17:16 2010
New Revision: 100914

URL: http://llvm.org/viewvc/llvm-project?rev=100914&view=rev
Log:
Disable diag::err_file_modified on Win32 completely, until someone cares to fix
it. PR6812.
 - This is another attempt at silencing annoying buildbot failures.

Modified:
    cfe/trunk/lib/Basic/SourceManager.cpp

Modified: cfe/trunk/lib/Basic/SourceManager.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/SourceManager.cpp?rev=100914&r1=100913&r2=100914&view=diff
==============================================================================
--- cfe/trunk/lib/Basic/SourceManager.cpp (original)
+++ cfe/trunk/lib/Basic/SourceManager.cpp Fri Apr  9 20:17:16 2010
@@ -98,24 +98,26 @@
           << Entry->getName() << ErrorStr;
 
       Buffer.setInt(true);
-    } else if (FileInfo.st_size != Entry->getSize()
+
+    // FIXME: This conditionalization is horrible, but we see spurious failures
+    // in the test suite due to this warning and no one has had time to hunt it
+    // down. So for now, we just don't emit this diagnostic on Win32, and hope
+    // nothing bad happens.
+    //
+    // PR6812.
 #if !defined(LLVM_ON_WIN32)
-               // In our regression testing, the Windows file system
-               // seems to have inconsistent modification times that
-               // sometimes erroneously trigger this error-handling
-               // path.
-               || FileInfo.st_mtime != Entry->getModificationTime()
-#endif
-               ) {
+    } else if (FileInfo.st_size != Entry->getSize() ||
+               FileInfo.st_mtime != Entry->getModificationTime()) {
       // Check that the file's size and modification time are the same
       // as in the file entry (which may have come from a stat cache).
       if (Diag.isDiagnosticInFlight())
-        Diag.SetDelayedDiagnostic(diag::err_file_modified, 
+        Diag.SetDelayedDiagnostic(diag::err_file_modified,
                                   Entry->getName());
-      else 
+      else
         Diag.Report(diag::err_file_modified) << Entry->getName();
 
       Buffer.setInt(true);
+#endif
     }
   }