[cfe-commits] r99823 - in /cfe/trunk/lib/CodeGen: CGDebugInfo.cpp CGDebugInfo.h

[Chris Lattner]

sounds great, thanks!

On Mar 29, 2010, at 12:11 PM, Ted Kremenek wrote:

>> Did you make sure that iterators aren't getting invalidated here?  If something does this:
>> 
>> 
>> WeakVH &H = TypeCache[x];
>> ... stuff that could insert or delete from TypeCache...
>> 
>> ... use H ...
>> 
>> Then this would be a bug,
> 
> The usage appears safe.  I also talked about this with Devang to see if we no longer needed an std::map.