[cfe-commits] r98722 - /cfe/trunk/lib/Frontend/CompilerInstance.cpp

[Kovarththanan Rajaratnam]

Author: krj
Date: Wed Mar 17 04:47:30 2010
New Revision: 98722

URL: http://llvm.org/viewvc/llvm-project?rev=98722&view=rev
Log:
Simplify error path using OwningPtr

Modified:
    cfe/trunk/lib/Frontend/CompilerInstance.cpp

Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInstance.cpp?rev=98722&r1=98721&r2=98722&view=diff
==============================================================================
--- cfe/trunk/lib/Frontend/CompilerInstance.cpp (original)
+++ cfe/trunk/lib/Frontend/CompilerInstance.cpp Wed Mar 17 04:47:30 2010
@@ -109,12 +109,11 @@
                               unsigned argc, char **argv,
                               Diagnostic &Diags) {
   std::string ErrorInfo;
-  llvm::raw_ostream *OS =
-    new llvm::raw_fd_ostream(DiagOpts.DumpBuildInformation.c_str(), ErrorInfo);
+  llvm::OwningPtr<llvm::raw_ostream> OS(
+    new llvm::raw_fd_ostream(DiagOpts.DumpBuildInformation.c_str(), ErrorInfo));
   if (!ErrorInfo.empty()) {
     Diags.Report(diag::err_fe_unable_to_open_logfile)
                  << DiagOpts.DumpBuildInformation << ErrorInfo;
-    delete OS;
     return;
   }
 
@@ -125,7 +124,7 @@
 
   // Chain in a diagnostic client which will log the diagnostics.
   DiagnosticClient *Logger =
-    new TextDiagnosticPrinter(*OS, DiagOpts, /*OwnsOutputStream=*/true);
+    new TextDiagnosticPrinter(*OS.take(), DiagOpts, /*OwnsOutputStream=*/true);
   Diags.setClient(new ChainedDiagnosticClient(Diags.getClient(), Logger));
 }