[cfe-commits] r98129 - /cfe/trunk/test/SemaCXX/PR6474.cpp

[John McCall]

On Mar 9, 2010, at 8:09 PM, Rafael Espíndola wrote:

>> Right, but introducing the necessary changes in Sema also required changes in CodeGen — which your test doesn't exercise at all.
>> 
>>> What is the canonical way of adding such tests?
>> 
>> Make a test in CodeGenCXX with a run line like
>>  RUN: %clang_cc1 -triple <something> -emit-llvm -o - %s | FileCheck %s
>> and then check for the existence (or non-existence, although that's trickier) of lines in the output you consider interesting.
> 
> The necessary changes in codegen are there to avoid an assertion
> failure. OK if I just move the test to CodeGenCXX and remove the
> -fsyntax-only?

If that's really all it's doing, then sure, move it and substitute -emit-llvm-only for -fsyntax-only.

John.