[cfe-commits] r98129 - /cfe/trunk/test/SemaCXX/PR6474.cpp

[John McCall]

On Mar 9, 2010, at 7:45 PM, Rafael Espíndola wrote:

>> This testcase, which purports to apply to a codegen patch, is run with -fsyntax-only.  Please have this test verify the emission/non-emission of functions/vtables/whatever with FileCheck.
> 
> Before the patch the testcase would be rejected by clang, so the test
> is just that clang accepts it.

Right, but introducing the necessary changes in Sema also required changes in CodeGen — which your test doesn't exercise at all.

> What is the canonical way of adding such tests?

Make a test in CodeGenCXX with a run line like
  RUN: %clang_cc1 -triple <something> -emit-llvm -o - %s | FileCheck %s
and then check for the existence (or non-existence, although that's trickier) of lines in the output you consider interesting.

John.