[cfe-commits] [patch] Add support for weakref

[Douglas Gregor]

Sent from my iPhone

On Feb 22, 2010, at 1:42 PM, Rafael Espindola <espindola at google.com>  
wrote:

>> I would rather have WeakRefAttr in the AST, so we model the source  
>> more closely. Codegen can just handle it the same way as "weak" or  
>> "alias weak", depending on whether the "alias" attribute is also  
>> present.
>>
>> Otherwise, this looks fine to me, but I admit that I don't have a  
>> solid understanding of weakref.
>
> It is fuzzy for me too. I am mostly trying to do what llvm-gcc does.
>
> I have update the patch to add a WeakRefAttr. I have also updated it
> to be more strict about what it accepts. It will now reject a weakref
> with a missing target. We can add that back if it is actually used.

Looks good. I'm AFK at the moment, but could you check that this  
attribute will be (de-)serialized correctly for PCH before committing?

>>        - Doug
>
> Cheers,
> -- 
> Rafael Ávila de Espíndola
> <weakref.patch>