[cfe-commits] r96600 - /cfe/trunk/tools/CIndex/CIndex.cpp

Ted Kremenek kremenek at apple.com
Thu Feb 18 14:36:21 PST 2010


Reverted.

On Feb 18, 2010, at 11:46 AM, Douglas Gregor wrote:

> 
> On Feb 18, 2010, at 10:47 AM, Ted Kremenek wrote:
> 
>> Author: kremenek
>> Date: Thu Feb 18 12:47:08 2010
>> New Revision: 96600
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=96600&view=rev
>> Log:
>> Sort visitor methods so we can easily tell what's implemented.
> 
> They were sorted in the order of DeclNodes.def, which I find easier because it groups subclasses together :(
> 
>> Modified:
>>   cfe/trunk/tools/CIndex/CIndex.cpp
>> 
>> Modified: cfe/trunk/tools/CIndex/CIndex.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/CIndex/CIndex.cpp?rev=96600&r1=96599&r2=96600&view=diff
>> 
>> ==============================================================================
>> --- cfe/trunk/tools/CIndex/CIndex.cpp (original)
>> +++ cfe/trunk/tools/CIndex/CIndex.cpp Thu Feb 18 12:47:08 2010
>> @@ -256,27 +256,27 @@
>>  // Declaration visitors
>>  bool VisitAttributes(Decl *D);
>>  bool VisitDeclContext(DeclContext *DC);
>> -  bool VisitTranslationUnitDecl(TranslationUnitDecl *D);
>> -  bool VisitTypedefDecl(TypedefDecl *D);
>> -  bool VisitTagDecl(TagDecl *D);
>> -  bool VisitEnumConstantDecl(EnumConstantDecl *D);
>>  bool VisitDeclaratorDecl(DeclaratorDecl *DD);
>> -  bool VisitFunctionDecl(FunctionDecl *ND);
>> +  bool VisitEnumConstantDecl(EnumConstantDecl *D);
>>  bool VisitFieldDecl(FieldDecl *D);
>> -  bool VisitVarDecl(VarDecl *);
>> -  bool VisitObjCMethodDecl(ObjCMethodDecl *ND);
>> -  bool VisitObjCContainerDecl(ObjCContainerDecl *D);
>> +  bool VisitFunctionDecl(FunctionDecl *ND);
>>  bool VisitObjCCategoryDecl(ObjCCategoryDecl *ND);
>> -  bool VisitObjCProtocolDecl(ObjCProtocolDecl *PID);
>> -  bool VisitObjCInterfaceDecl(ObjCInterfaceDecl *D);
>> -  bool VisitObjCImplDecl(ObjCImplDecl *D);
>>  bool VisitObjCCategoryImplDecl(ObjCCategoryImplDecl *D);
>> +  bool VisitObjCClassDecl(ObjCClassDecl *D);
>> +  // FIXME: ObjCCompatibleAliasDecl requires aliased-class locations.
>> +  bool VisitObjCContainerDecl(ObjCContainerDecl *D);
>> +  bool VisitObjCForwardProtocolDecl(ObjCForwardProtocolDecl *D);
>> +  bool VisitObjCImplDecl(ObjCImplDecl *D);
>>  bool VisitObjCImplementationDecl(ObjCImplementationDecl *D);
>> +  bool VisitObjCInterfaceDecl(ObjCInterfaceDecl *D);
>> +  bool VisitObjCMethodDecl(ObjCMethodDecl *ND);
>>  // FIXME: ObjCPropertyDecl requires TypeSourceInfo, getter/setter locations,
>>  // etc.
>> -  // FIXME: ObjCCompatibleAliasDecl requires aliased-class locations.
>> -  bool VisitObjCForwardProtocolDecl(ObjCForwardProtocolDecl *D);
>> -  bool VisitObjCClassDecl(ObjCClassDecl *D);
>> +  bool VisitObjCProtocolDecl(ObjCProtocolDecl *PID);
>> +  bool VisitTagDecl(TagDecl *D);
>> +  bool VisitTranslationUnitDecl(TranslationUnitDecl *D);
>> +  bool VisitTypedefDecl(TypedefDecl *D);
>> +  bool VisitVarDecl(VarDecl *);
>> 
>>  // Type visitors
>>  // FIXME: QualifiedTypeLoc doesn't provide any location information
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 





More information about the cfe-commits mailing list