[cfe-commits] r96602 - /cfe/trunk/tools/CIndex/CIndex.cpp

[Ted Kremenek]

Done.

On Feb 18, 2010, at 1:27 PM, Chris Lattner wrote:

> 
> On Feb 18, 2010, at 10:52 AM, Ted Kremenek wrote:
> 
>> Author: kremenek
>> Date: Thu Feb 18 12:52:18 2010
>> New Revision: 96602
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=96602&view=rev
>> Log:
>> Tidy up order of switch statement.  No functionality change.
> 
> This was previously sorted by size.  With your lexicographic sort, the various char's are no longer together (Char_U + UChar).  Please revert.
> 
> -Chris
> 
>> 
>> Modified:
>>   cfe/trunk/tools/CIndex/CIndex.cpp
>> 
>> Modified: cfe/trunk/tools/CIndex/CIndex.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/CIndex/CIndex.cpp?rev=96602&r1=96601&r2=96602&view=diff
>> 
>> ==============================================================================
>> --- cfe/trunk/tools/CIndex/CIndex.cpp (original)
>> +++ cfe/trunk/tools/CIndex/CIndex.cpp Thu Feb 18 12:52:18 2010
>> @@ -644,47 +644,43 @@
>>  // "Class") have associated declarations. Create cursors for those.
>>  QualType VisitType;
>>  switch (TL.getType()->getAs<BuiltinType>()->getKind()) {
>> -  case BuiltinType::Void:
>>  case BuiltinType::Bool:
>> -  case BuiltinType::Char_U:
>> -  case BuiltinType::UChar:
>>  case BuiltinType::Char16:
>>  case BuiltinType::Char32:
>> -  case BuiltinType::UShort:
>> -  case BuiltinType::UInt:
>> -  case BuiltinType::ULong:
>> -  case BuiltinType::ULongLong:
>> -  case BuiltinType::UInt128:
>>  case BuiltinType::Char_S:
>> -  case BuiltinType::SChar:
>> -  case BuiltinType::WChar:
>> -  case BuiltinType::Short:
>> +  case BuiltinType::Char_U:
>> +  case BuiltinType::Dependent:
>> +  case BuiltinType::Double:
>> +  case BuiltinType::Float:
>> +  case BuiltinType::Int128:
>>  case BuiltinType::Int:
>>  case BuiltinType::Long:
>> -  case BuiltinType::LongLong:
>> -  case BuiltinType::Int128:
>> -  case BuiltinType::Float:
>> -  case BuiltinType::Double:
>>  case BuiltinType::LongDouble:
>> +  case BuiltinType::LongLong:
>>  case BuiltinType::NullPtr:
>>  case BuiltinType::Overload:
>> -  case BuiltinType::Dependent:
>> +  case BuiltinType::SChar:
>> +  case BuiltinType::Short:
>> +  case BuiltinType::UChar:
>> +  case BuiltinType::UInt128:
>> +  case BuiltinType::UInt:
>> +  case BuiltinType::ULong:
>> +  case BuiltinType::ULongLong:
>> +  case BuiltinType::UShort:
>> +  case BuiltinType::Void:
>> +  case BuiltinType::WChar:
>>    break;
>> -
>> -  case BuiltinType::UndeducedAuto: // FIXME: Deserves a cursor?
>> +  case BuiltinType::ObjCClass:
>> +    VisitType = Context.getObjCClassType();
>>    break;
>> -
>>  case BuiltinType::ObjCId:
>>    VisitType = Context.getObjCIdType();
>>    break;
>> -
>> -  case BuiltinType::ObjCClass:
>> -    VisitType = Context.getObjCClassType();
>> -    break;
>> -
>>  case BuiltinType::ObjCSel:
>>    VisitType = Context.getObjCSelType();
>>    break;
>> +  case BuiltinType::UndeducedAuto: // FIXME: Deserves a cursor?
>> +    break;
>>  }
>> 
>>  if (!VisitType.isNull()) {
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>