[cfe-commits] [PATCH] Handle __declspec(dllimport) and __declspec(dllexport)

[Charles Davis]

Charles Davis wrote:
> Anton Korobeynikov wrote:
>> Hello, Charles
>>
>>> appropriately. As far as I know, these are the only two declspec
>>> attributes that clang supports at the moment. It fixes the reporter's
>>> immediate problem, but I wouldn't call the bug "fixed" because of the
>>> many, many MS declspec attributes we don't support yet.
>> Right. That's why it make sense to move the handling of these
>> attributes to TargetSema (possible slightly extending this interface).
>> Could you please consider this way?
> Yeah, I could do that.
> 
> The problem is that these aren't x86-specific attributes. They're
> Windows/Symbian-specific attributes. So now, the way I envision it, we
> need another class hierarchy for OS-specific attributes as opposed to
> architecture-specific attributes. (In actuality, I'll probably create
> another subclass of TargetAttributesSema for this instance, and then add
> a new method, getOSTargetAttributesSema() to get something from this new
> family.)
And here's a patch which does just that.

While I was at it, I also fixed a test to use FileCheck (which I know
Chris likes to see) instead of grepping LLVM IR.

Chip

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ds-support-1.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100216/0c8a41a6/attachment.ksh>