[cfe-commits] r95820 - in /cfe/trunk: include/clang/AST/Attr.h lib/AST/AttrImpl.cpp lib/Sema/TargetAttributesSema.cpp test/Sema/x86-attr-force-align-arg-pointer.c

[Charles Davis]

Douglas Gregor wrote:
> On Feb 11, 2010, at 9:04 AM, Charles Davis wrote:
> 
>> Daniel Dunbar wrote:
>>> It might be a good idea to warn anyway. If a user is trying to do
>>> something which does nothing, they are probably confused and it may be
>>> worth pointing out.
>> GCC does not warn. Also, if we did warn, anyone who tried to compile,
>> say, Wine on Mac OS X would get a ton of warnings because Wine uses this
>> on function pointers. (They actually use __stdcall, but they define it
>> to __attribute__((stdcall)) __attribute__((force_align_arg_pointer)) on
>> Mac OS X because of the 16-byte alignment requirement.)
> 
> One easy fix for that problem is to give the warning a -W option. Users who want to ignore the warning can use -Wno-blah.
There, now we warn about using force_align_arg_pointer by default.
Committed as r95939.

Chip