[cfe-commits] r95151 - /cfe/trunk/lib/Checker/RegionStore.cpp

[Benjamin Kramer]

Am 02.02.2010 um 23:38 schrieb Ted Kremenek:

> Author: kremenek
> Date: Tue Feb  2 16:38:47 2010
> New Revision: 95151
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=95151&view=rev
> Log:
> Remove RegionStoreSubRegionMap::iterator and RegionStoreSubRegionMap::begin_end().  This is a precursor to using DenseSet to represent region sets instead of ImmutableSet.
> 
> Modified:
>    cfe/trunk/lib/Checker/RegionStore.cpp
…
> @@ -235,7 +233,7 @@
>   RegionStoreManager(GRStateManager& mgr, const RegionStoreFeatures &f)
>     : StoreManager(mgr),
>       Features(f),
> -      RBFactory(mgr.getAllocator()) {}
> +      RBFactory(mgr.getAllocator(), 3) {}
                                       ^
Hi Ted,

ImmutableMap::Factory's constructor is declared as:
Factory(BumpPtrAllocator& Alloc, bool canonicalize = true)

what's the reason behind the '3'?


MSVC warns: RegionStore.cpp(211) : warning C4305: 'argument' : truncation from 'int' to 'bool'
> 
>   virtual ~RegionStoreManager() {
>     for (SMCache::iterator I = SC.begin(), E = SC.end(); I != E; ++I)