[cfe-commits] r94531 - in /cfe/trunk: include/clang/AST/ExprCXX.h lib/Sema/SemaOverload.cpp

[John McCall]

Author: rjmccall
Date: Tue Jan 26 01:37:41 2010
New Revision: 94531

URL: http://llvm.org/viewvc/llvm-project?rev=94531&view=rev
Log:
Avoid some unnecessary copying of unresolved lookup results.


Modified:
    cfe/trunk/include/clang/AST/ExprCXX.h
    cfe/trunk/lib/Sema/SemaOverload.cpp

Modified: cfe/trunk/include/clang/AST/ExprCXX.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/ExprCXX.h?rev=94531&r1=94530&r2=94531&view=diff

==============================================================================
--- cfe/trunk/include/clang/AST/ExprCXX.h (original)
+++ cfe/trunk/include/clang/AST/ExprCXX.h Tue Jan 26 01:37:41 2010
@@ -1149,6 +1149,9 @@
   decls_iterator decls_begin() const { return Results.begin(); }
   decls_iterator decls_end() const { return Results.end(); }
 
+  /// Retrieves the decls as an unresolved set.
+  const UnresolvedSetImpl &getDecls() { return Results; }
+
   /// True if this declaration should be extended by
   /// argument-dependent lookup.
   bool requiresADL() const { return RequiresADL; }
@@ -1805,6 +1808,9 @@
 
   unsigned getNumDecls() const { return Results.size(); }
 
+  /// Retrieves the decls as an unresolved set.
+  const UnresolvedSetImpl &getDecls() { return Results; }
+
   /// \brief True if this is an implicit access, i.e. one in which the
   /// member being accessed was not written in the source.  The source
   /// location of the operator is invalid in this case.

Modified: cfe/trunk/lib/Sema/SemaOverload.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaOverload.cpp?rev=94531&r1=94530&r2=94531&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaOverload.cpp (original)
+++ cfe/trunk/lib/Sema/SemaOverload.cpp Tue Jan 26 01:37:41 2010
@@ -4903,36 +4903,34 @@
 
   bool HasExplicitTemplateArgs = false;
   TemplateArgumentListInfo ExplicitTemplateArgs;
-
-  llvm::SmallVector<NamedDecl*,8> Fns;
+  const UnresolvedSetImpl *Fns;
   
   // Look into the overloaded expression.
   if (UnresolvedLookupExpr *UL
                = dyn_cast<UnresolvedLookupExpr>(OvlExpr)) {
-    Fns.append(UL->decls_begin(), UL->decls_end());
+    Fns = &UL->getDecls();
     if (UL->hasExplicitTemplateArgs()) {
       HasExplicitTemplateArgs = true;
       UL->copyTemplateArgumentsInto(ExplicitTemplateArgs);
     }
   } else if (UnresolvedMemberExpr *ME
                = dyn_cast<UnresolvedMemberExpr>(OvlExpr)) {
-    Fns.append(ME->decls_begin(), ME->decls_end());
+    Fns = &ME->getDecls();
     if (ME->hasExplicitTemplateArgs()) {
       HasExplicitTemplateArgs = true;
       ME->copyTemplateArgumentsInto(ExplicitTemplateArgs);
     }
-  }
+  } else return 0;
 
   // If we didn't actually find anything, we're done.
-  if (Fns.empty())
+  if (Fns->empty())
     return 0;
 
   // Look through all of the overloaded functions, searching for one
   // whose type matches exactly.
   llvm::SmallPtrSet<FunctionDecl *, 4> Matches;
   bool FoundNonTemplateFunction = false;
-  for (llvm::SmallVectorImpl<NamedDecl*>::iterator I = Fns.begin(),
-         E = Fns.end(); I != E; ++I) {
+  for (UnresolvedSetIterator I = Fns->begin(), E = Fns->end(); I != E; ++I) {
     // Look through any using declarations to find the underlying function.
     NamedDecl *Fn = (*I)->getUnderlyingDecl();
 
@@ -5088,35 +5086,33 @@
   
   bool HasExplicitTemplateArgs = false;
   TemplateArgumentListInfo ExplicitTemplateArgs;
-  
-  llvm::SmallVector<NamedDecl*,8> Fns;
+  const UnresolvedSetImpl *Fns;
   
   // Look into the overloaded expression.
   if (UnresolvedLookupExpr *UL
       = dyn_cast<UnresolvedLookupExpr>(OvlExpr)) {
-    Fns.append(UL->decls_begin(), UL->decls_end());
+    Fns = &UL->getDecls();
     if (UL->hasExplicitTemplateArgs()) {
       HasExplicitTemplateArgs = true;
       UL->copyTemplateArgumentsInto(ExplicitTemplateArgs);
     }
   } else if (UnresolvedMemberExpr *ME
              = dyn_cast<UnresolvedMemberExpr>(OvlExpr)) {
-    Fns.append(ME->decls_begin(), ME->decls_end());
+    Fns = &ME->getDecls();
     if (ME->hasExplicitTemplateArgs()) {
       HasExplicitTemplateArgs = true;
       ME->copyTemplateArgumentsInto(ExplicitTemplateArgs);
     }
-  }
+  } else return 0;
   
   // If we didn't actually find any template-ids, we're done.
-  if (Fns.empty() || !HasExplicitTemplateArgs)
+  if (Fns->empty() || !HasExplicitTemplateArgs)
     return 0;
   
   // Look through all of the overloaded functions, searching for one
   // whose type matches exactly.
   FunctionDecl *Matched = 0;
-  for (llvm::SmallVectorImpl<NamedDecl*>::iterator I = Fns.begin(),
-       E = Fns.end(); I != E; ++I) {
+  for (UnresolvedSetIterator I = Fns->begin(), E = Fns->end(); I != E; ++I) {
     // C++0x [temp.arg.explicit]p3:
     //   [...] In contexts where deduction is done and fails, or in contexts
     //   where deduction is not done, if a template argument list is