[cfe-commits] r94434 - in /cfe/trunk: lib/CodeGen/CGDeclCXX.cpp test/CodeGenCXX/reference-init.cpp

[Anders Carlsson]

On Jan 25, 2010, at 10:30 AM, Fariborz Jahanian wrote:

> Author: fjahanian
> Date: Mon Jan 25 12:30:26 2010
> New Revision: 94434
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=94434&view=rev
> Log:
> Fix a code gen. bug involving compiling global references.
> (fixes radar 7574896).
> 

Hi Fariborz,

this fix is not complete. For example, it doesn't work with:

struct A { 
  A();
  ~A();
};

const A& a = A();

I think you could check if Init is an lvalue and only bind it in that case (and ErrorUnsupported if it's not an lvalue).

Anders