[cfe-commits] r94366 - in /cfe/trunk: include/clang/AST/DeclCXX.h test/SemaCXX/explicit.cpp

[Chris Lattner]

On Jan 24, 2010, at 9:15 AM, Anders Carlsson wrote:

> URL: http://llvm.org/viewvc/llvm-project?rev=94366&view=rev
> Log:
> Fix a pretty bad bug where if a constructor (or conversion function) was marked as 'explicit', but then defined out-of-line, we would not treat it as being explicit.
> 
> Added:
>    cfe/trunk/test/SemaCXX/explicit.cpp
> Modified:
>    cfe/trunk/include/clang/AST/DeclCXX.h
> 
> Modified: cfe/trunk/include/clang/AST/DeclCXX.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclCXX.h?rev=94366&r1=94365&r2=94366&view=diff
> 
> ==============================================================================
> --- cfe/trunk/include/clang/AST/DeclCXX.h (original)
> +++ cfe/trunk/include/clang/AST/DeclCXX.h Sun Jan 24 11:15:04 2010
> @@ -1084,8 +1084,9 @@
> /// };
> /// @endcode
> class CXXConstructorDecl : public CXXMethodDecl {
> -  /// Explicit - Whether this constructor is explicit.
> -  bool Explicit : 1;
> +  /// Explicit - Whether this constructor declaration has the
> +  /// 'explicit' keyword specified.
> +  bool IsExplicitSpecified : 1;

Hi Anders, please update the 'Explicit' in the comment too, thanks!

-Chris