[cfe-commits] r94173 - in /cfe/trunk: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/virtual-override.cpp
Anders Carlsson
andersca at mac.com
Fri Jan 22 08:42:46 PST 2010
22 jan 2010 kl. 07.08 skrev Douglas Gregor:
>
> I find this code a bit strange... why is it mapping down to the canonical type then using dyn_cast? It would be simpler just to keep the original source types and use getAs<> rather than dyn_cast. Then we'll get better typedef information in the diagnostics, and I won't have to panic every time I see dyn_cast<> on types.
>
Yeah, that was just a premature optimization done by me :) I'll fix it.
Anders
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100122/358f9119/attachment.html>
More information about the cfe-commits
mailing list