[cfe-commits] r94005 - /cfe/trunk/lib/Sema/SemaDeclObjC.cpp

[Fariborz Jahanian]

Author: fjahanian
Date: Wed Jan 20 11:27:59 2010
New Revision: 94005

URL: http://llvm.org/viewvc/llvm-project?rev=94005&view=rev
Log:
Improve performance of warning when not implementing a required 
property of a protocol (my previous patch). No change in functionality.
(radar 7544809).

Modified:
    cfe/trunk/lib/Sema/SemaDeclObjC.cpp

Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclObjC.cpp?rev=94005&r1=94004&r2=94005&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclObjC.cpp Wed Jan 20 11:27:59 2010
@@ -1121,24 +1121,24 @@
                                       const llvm::DenseSet<Selector>& InsMap) {
   llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap;
   CollectImmediateProperties(CDecl, PropMap);
-
+  if (PropMap.empty())
+    return;
+  
+  llvm::DenseSet<ObjCPropertyDecl *> PropImplMap;
+  for (ObjCImplDecl::propimpl_iterator
+       I = IMPDecl->propimpl_begin(),
+       EI = IMPDecl->propimpl_end(); I != EI; ++I)
+    PropImplMap.insert((*I)->getPropertyDecl());
+  
   for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 
        P = PropMap.begin(), E = PropMap.end(); P != E; ++P) {
     ObjCPropertyDecl *Prop = P->second;
-    if (Prop->isInvalidDecl() ||
-        Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional)
-      continue;
-    ObjCPropertyImplDecl *PI = 0;
     // Is there a matching propery synthesize/dynamic?
-    for (ObjCImplDecl::propimpl_iterator
-         I = IMPDecl->propimpl_begin(),
-         EI = IMPDecl->propimpl_end(); I != EI; ++I)
-      if ((*I)->getPropertyDecl() == Prop) {
-        PI = (*I);
-        break;
-      }
-    if (PI)
+    if (Prop->isInvalidDecl() ||
+        Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional ||
+        PropImplMap.count(Prop))
       continue;
+  
     if (!InsMap.count(Prop->getGetterName())) {
       Diag(Prop->getLocation(),
            diag::warn_setter_getter_impl_required)