[cfe-commits] r93088 - in /cfe/trunk: lib/Frontend/InitPreprocessor.cpp test/Frontend/macros.c

[Daniel Dunbar]

Author: ddunbar
Date: Sat Jan  9 18:46:21 2010
New Revision: 93088

URL: http://llvm.org/viewvc/llvm-project?rev=93088&view=rev
Log:
Fix PR5982, a refacto in checking for '=' in a -D argument.

Added:
    cfe/trunk/test/Frontend/macros.c
Modified:
    cfe/trunk/lib/Frontend/InitPreprocessor.cpp

Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/InitPreprocessor.cpp?rev=93088&r1=93087&r2=93088&view=diff

==============================================================================
--- cfe/trunk/lib/Frontend/InitPreprocessor.cpp (original)
+++ cfe/trunk/lib/Frontend/InitPreprocessor.cpp Sat Jan  9 18:46:21 2010
@@ -27,19 +27,16 @@
 // in which case we emit "#define XXX 1" or "XXX=Y z W" in which case we emit
 // "#define XXX Y z W".  To get a #define with no value, use "XXX=".
 static void DefineBuiltinMacro(MacroBuilder &Builder, llvm::StringRef Macro,
-                               Diagnostic *Diags = 0) {
+                               Diagnostic &Diags) {
   std::pair<llvm::StringRef, llvm::StringRef> MacroPair = Macro.split('=');
   llvm::StringRef MacroName = MacroPair.first;
   llvm::StringRef MacroBody = MacroPair.second;
-  if (!MacroBody.empty()) {
+  if (MacroName.size() != Macro.size()) {
     // Per GCC -D semantics, the macro ends at \n if it exists.
     llvm::StringRef::size_type End = MacroBody.find_first_of("\n\r");
-    if (End != llvm::StringRef::npos) {
-      assert(Diags && "Unexpected macro with embedded newline!");
-      Diags->Report(diag::warn_fe_macro_contains_embedded_newline)
+    if (End != llvm::StringRef::npos)
+      Diags.Report(diag::warn_fe_macro_contains_embedded_newline)
         << MacroName;
-    }
-
     Builder.defineMacro(MacroName, MacroBody.substr(0, End));
   } else {
     // Push "macroname 1".
@@ -490,7 +487,7 @@
       Builder.undefineMacro(InitOpts.Macros[i].first);
     else
       DefineBuiltinMacro(Builder, InitOpts.Macros[i].first,
-                         &PP.getDiagnostics());
+                         PP.getDiagnostics());
   }
 
   // If -imacros are specified, include them now.  These are processed before

Added: cfe/trunk/test/Frontend/macros.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/macros.c?rev=93088&view=auto

==============================================================================
--- cfe/trunk/test/Frontend/macros.c (added)
+++ cfe/trunk/test/Frontend/macros.c Sat Jan  9 18:46:21 2010
@@ -0,0 +1,4 @@
+// RUN: %clang_cc1 -DA= -DB=1 -verify -fsyntax-only %s
+
+int a[(B A) == 1 ? 1 : -1];
+