[cfe-commits] r91779 - in /cfe/trunk: include/clang/AST/ include/clang/Analysis/ include/clang/Analysis/FlowSensitive/ include/clang/Analysis/PathSensitive/ include/clang/Parse/ lib/CodeGen/ lib/Driver/

Daniel Dunbar daniel at zuster.org
Sat Dec 19 11:07:51 PST 2009 

On Sat, Dec 19, 2009 at 9:53 AM, Douglas Gregor <dgregor at apple.com> wrote:
> On Dec 19, 2009, at 9:50 AM, Daniel Dunbar <daniel at zuster.org> wrote:
>
>> Author: ddunbar
>> Date: Sat Dec 19 11:50:07 2009
>> New Revision: 91779
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=91779&view=rev
>> Log:
>> Remove ';' after method definition. Noticed by clang++, which one would
>> think
>> would have a higher respect for its own code. This is getting old, is this
>> warning really adding value?
>
> It's a -pedantic warning, which seems like the right level.

Right, seems fair, I forgot we compiled with -pedantic. We are getting
our just deserts, I suppose. :)

 - Daniel

> We could make -fixit-inplace do this magic for us:)
>
>> Modified:
>>   cfe/trunk/include/clang/AST/CanonicalType.h
>>   cfe/trunk/include/clang/AST/Decl.h
>>   cfe/trunk/include/clang/AST/DeclObjC.h
>>   cfe/trunk/include/clang/AST/TemplateBase.h
>>   cfe/trunk/include/clang/Analysis/CFG.h
>>   cfe/trunk/include/clang/Analysis/FlowSensitive/DataflowValues.h
>>   cfe/trunk/include/clang/Analysis/PathDiagnostic.h
>>   cfe/trunk/include/clang/Analysis/PathSensitive/AnalysisManager.h
>>   cfe/trunk/include/clang/Analysis/PathSensitive/ExplodedGraph.h
>>   cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h
>>   cfe/trunk/include/clang/Analysis/PathSensitive/Store.h
>>   cfe/trunk/include/clang/Parse/Action.h
>>   cfe/trunk/lib/CodeGen/CGExprScalar.cpp
>>   cfe/trunk/lib/CodeGen/CGRTTI.cpp
>>   cfe/trunk/lib/CodeGen/ModuleBuilder.cpp
>>   cfe/trunk/lib/Driver/Tools.h
>>
>> Modified: cfe/trunk/include/clang/AST/CanonicalType.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/CanonicalType.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/AST/CanonicalType.h (original)
>> +++ cfe/trunk/include/clang/AST/CanonicalType.h Sat Dec 19 11:50:07 2009
>> @@ -559,7 +559,7 @@
>> struct CanProxyAdaptor<FunctionProtoType>
>>  : public CanProxyBase<FunctionProtoType> {
>>  LLVM_CLANG_CANPROXY_TYPE_ACCESSOR(getResultType)
>> -  LLVM_CLANG_CANPROXY_SIMPLE_ACCESSOR(unsigned, getNumArgs);
>> +  LLVM_CLANG_CANPROXY_SIMPLE_ACCESSOR(unsigned, getNumArgs)
>>  CanQualType getArgType(unsigned i) const {
>>    return CanQualType::CreateUnsafe(this->getTypePtr()->getArgType(i));
>>  }
>>
>> Modified: cfe/trunk/include/clang/AST/Decl.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Decl.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/AST/Decl.h (original)
>> +++ cfe/trunk/include/clang/AST/Decl.h Sat Dec 19 11:50:07 2009
>> @@ -1180,7 +1180,7 @@
>>  /// represents an C++ overloaded operator, e.g., "operator+".
>>  bool isOverloadedOperator() const {
>>    return getOverloadedOperator() != OO_None;
>> -  };
>> +  }
>>
>>  OverloadedOperatorKind getOverloadedOperator() const;
>>
>>
>> Modified: cfe/trunk/include/clang/AST/DeclObjC.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclObjC.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/AST/DeclObjC.h (original)
>> +++ cfe/trunk/include/clang/AST/DeclObjC.h Sat Dec 19 11:50:07 2009
>> @@ -527,7 +527,7 @@
>>  // Location information, modeled after the Stmt API.
>>  SourceLocation getLocStart() const { return getLocation(); } //
>> '@'interface
>>  SourceLocation getLocEnd() const { return EndLoc; }
>> -  void setLocEnd(SourceLocation LE) { EndLoc = LE; };
>> +  void setLocEnd(SourceLocation LE) { EndLoc = LE; }
>>
>>  void setClassLoc(SourceLocation Loc) { ClassLoc = Loc; }
>>  SourceLocation getClassLoc() const { return ClassLoc; }
>> @@ -707,7 +707,7 @@
>>  // Location information, modeled after the Stmt API.
>>  SourceLocation getLocStart() const { return getLocation(); } //
>> '@'protocol
>>  SourceLocation getLocEnd() const { return EndLoc; }
>> -  void setLocEnd(SourceLocation LE) { EndLoc = LE; };
>> +  void setLocEnd(SourceLocation LE) { EndLoc = LE; }
>>
>>  static bool classof(const Decl *D) { return D->getKind() == ObjCProtocol;
>> }
>>  static bool classof(const ObjCProtocolDecl *D) { return true; }
>> @@ -871,7 +871,7 @@
>>  // Location information, modeled after the Stmt API.
>>  SourceLocation getLocStart() const { return getLocation(); } //
>> '@'interface
>>  SourceLocation getLocEnd() const { return EndLoc; }
>> -  void setLocEnd(SourceLocation LE) { EndLoc = LE; };
>> +  void setLocEnd(SourceLocation LE) { EndLoc = LE; }
>>
>>  static bool classof(const Decl *D) { return D->getKind() == ObjCCategory;
>> }
>>  static bool classof(const ObjCCategoryDecl *D) { return true; }
>>
>> Modified: cfe/trunk/include/clang/AST/TemplateBase.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/TemplateBase.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/AST/TemplateBase.h (original)
>> +++ cfe/trunk/include/clang/AST/TemplateBase.h Sat Dec 19 11:50:07 2009
>> @@ -221,7 +221,7 @@
>>    assert(Kind == Integral &&
>>           "Cannot set the integral type of a non-integral template
>> argument");
>>    Integer.Type = T.getAsOpaquePtr();
>> -  };
>> +  }
>>
>>  /// \brief Retrieve the template argument as an expression.
>>  Expr *getAsExpr() const {
>>
>> Modified: cfe/trunk/include/clang/Analysis/CFG.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/CFG.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Analysis/CFG.h (original)
>> +++ cfe/trunk/include/clang/Analysis/CFG.h Sat Dec 19 11:50:07 2009
>> @@ -134,7 +134,7 @@
>>  explicit CFGBlock(unsigned blockid, BumpVectorContext &C)
>>    : Stmts(C), Label(NULL), Terminator(NULL), LoopTarget(NULL),
>>      BlockID(blockid), Preds(C, 1), Succs(C, 1) {}
>> -  ~CFGBlock() {};
>> +  ~CFGBlock() {}
>>
>>  // Statement iterators
>>  typedef StatementList::iterator                      iterator;
>> @@ -345,7 +345,7 @@
>>
>>  //===--------------------------------------------------------------------===//
>>
>>  CFG() : Entry(NULL), Exit(NULL), IndirectGotoBlock(NULL), NumBlockIDs(0),
>> -          BlkExprMap(NULL), Blocks(BlkBVC, 10) {};
>> +          BlkExprMap(NULL), Blocks(BlkBVC, 10) {}
>>
>>  ~CFG();
>>
>>
>> Modified: cfe/trunk/include/clang/Analysis/FlowSensitive/DataflowValues.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/FlowSensitive/DataflowValues.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Analysis/FlowSensitive/DataflowValues.h
>> (original)
>> +++ cfe/trunk/include/clang/Analysis/FlowSensitive/DataflowValues.h Sat
>> Dec 19 11:50:07 2009
>> @@ -79,7 +79,7 @@
>>
>>  /// InitializeValues - Invoked by the solver to initialize state needed
>> for
>>  ///  dataflow analysis.  This method is usually specialized by
>> subclasses.
>> -  void InitializeValues(const CFG& cfg) {};
>> +  void InitializeValues(const CFG& cfg) {}
>>
>>
>>  /// getEdgeData - Retrieves the dataflow values associated with a
>>
>> Modified: cfe/trunk/include/clang/Analysis/PathDiagnostic.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathDiagnostic.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Analysis/PathDiagnostic.h (original)
>> +++ cfe/trunk/include/clang/Analysis/PathDiagnostic.h Sat Dec 19 11:50:07
>> 2009
>> @@ -37,7 +37,7 @@
>> public:
>>  PathDiagnosticClient() {}
>>
>> -  virtual ~PathDiagnosticClient() {};
>> +  virtual ~PathDiagnosticClient() {}
>>
>>  virtual void
>>  FlushDiagnostics(llvm::SmallVectorImpl<std::string> *FilesMade = 0) = 0;
>>
>> Modified: cfe/trunk/include/clang/Analysis/PathSensitive/AnalysisManager.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/AnalysisManager.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Analysis/PathSensitive/AnalysisManager.h
>> (original)
>> +++ cfe/trunk/include/clang/Analysis/PathSensitive/AnalysisManager.h Sat
>> Dec 19 11:50:07 2009
>> @@ -73,7 +73,7 @@
>>
>>  StoreManagerCreator getStoreManagerCreator() {
>>    return CreateStoreMgr;
>> -  };
>> +  }
>>
>>  ConstraintManagerCreator getConstraintManagerCreator() {
>>    return CreateConstraintMgr;
>>
>> Modified: cfe/trunk/include/clang/Analysis/PathSensitive/ExplodedGraph.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/ExplodedGraph.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Analysis/PathSensitive/ExplodedGraph.h
>> (original)
>> +++ cfe/trunk/include/clang/Analysis/PathSensitive/ExplodedGraph.h Sat Dec
>> 19 11:50:07 2009
>> @@ -207,7 +207,7 @@
>> public:
>>  ExplodedNode* getMappedNode(const ExplodedNode* N) const;
>>
>> -  InterExplodedGraphMap() {};
>> +  InterExplodedGraphMap() {}
>>  virtual ~InterExplodedGraphMap() {}
>> };
>>
>>
>> Modified: cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h (original)
>> +++ cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h Sat Dec 19
>> 11:50:07 2009
>> @@ -58,7 +58,7 @@
>>
>> public:
>>  SVal() : Data(0), Kind(0) {}
>> -  ~SVal() {};
>> +  ~SVal() {}
>>
>>  /// BufferTy - A temporary buffer to hold a set of SVals.
>>  typedef llvm::SmallVector<SVal,5> BufferTy;
>>
>> Modified: cfe/trunk/include/clang/Analysis/PathSensitive/Store.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/Store.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Analysis/PathSensitive/Store.h (original)
>> +++ cfe/trunk/include/clang/Analysis/PathSensitive/Store.h Sat Dec 19
>> 11:50:07 2009
>> @@ -204,7 +204,7 @@
>>
>>  class Visitor {
>>  public:
>> -    virtual ~Visitor() {};
>> +    virtual ~Visitor() {}
>>    virtual bool Visit(const MemRegion* Parent, const MemRegion* SubRegion)
>> = 0;
>>  };
>>
>>
>> Modified: cfe/trunk/include/clang/Parse/Action.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Parse/Action.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Parse/Action.h (original)
>> +++ cfe/trunk/include/clang/Parse/Action.h Sat Dec 19 11:50:07 2009
>> @@ -1750,7 +1750,7 @@
>>                                         ASTTemplateArgsPtr TemplateArgs,
>>                                         SourceLocation RAngleLoc) {
>>    return TypeResult();
>> -  };
>> +  }
>>
>>  /// \brief Note that a template ID was used with a tag.
>>  ///
>>
>> Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Sat Dec 19 11:50:07 2009
>> @@ -328,16 +328,16 @@
>>  Value *VisitBin ## OP ## Assign(const CompoundAssignOperator *E) {
>> \
>>    return EmitCompoundAssign(E, &ScalarExprEmitter::Emit ## OP);
>>  \
>>  }
>> -  HANDLEBINOP(Mul);
>> -  HANDLEBINOP(Div);
>> -  HANDLEBINOP(Rem);
>> -  HANDLEBINOP(Add);
>> -  HANDLEBINOP(Sub);
>> -  HANDLEBINOP(Shl);
>> -  HANDLEBINOP(Shr);
>> -  HANDLEBINOP(And);
>> -  HANDLEBINOP(Xor);
>> -  HANDLEBINOP(Or);
>> +  HANDLEBINOP(Mul)
>> +  HANDLEBINOP(Div)
>> +  HANDLEBINOP(Rem)
>> +  HANDLEBINOP(Add)
>> +  HANDLEBINOP(Sub)
>> +  HANDLEBINOP(Shl)
>> +  HANDLEBINOP(Shr)
>> +  HANDLEBINOP(And)
>> +  HANDLEBINOP(Xor)
>> +  HANDLEBINOP(Or)
>> #undef HANDLEBINOP
>>
>>  // Comparisons.
>> @@ -347,12 +347,12 @@
>>    Value *VisitBin##CODE(const BinaryOperator *E) { \
>>      return EmitCompare(E, llvm::ICmpInst::UI, llvm::ICmpInst::SI, \
>>                         llvm::FCmpInst::FP); }
>> -  VISITCOMP(LT, ICMP_ULT, ICMP_SLT, FCMP_OLT);
>> -  VISITCOMP(GT, ICMP_UGT, ICMP_SGT, FCMP_OGT);
>> -  VISITCOMP(LE, ICMP_ULE, ICMP_SLE, FCMP_OLE);
>> -  VISITCOMP(GE, ICMP_UGE, ICMP_SGE, FCMP_OGE);
>> -  VISITCOMP(EQ, ICMP_EQ , ICMP_EQ , FCMP_OEQ);
>> -  VISITCOMP(NE, ICMP_NE , ICMP_NE , FCMP_UNE);
>> +  VISITCOMP(LT, ICMP_ULT, ICMP_SLT, FCMP_OLT)
>> +  VISITCOMP(GT, ICMP_UGT, ICMP_SGT, FCMP_OGT)
>> +  VISITCOMP(LE, ICMP_ULE, ICMP_SLE, FCMP_OLE)
>> +  VISITCOMP(GE, ICMP_UGE, ICMP_SGE, FCMP_OGE)
>> +  VISITCOMP(EQ, ICMP_EQ , ICMP_EQ , FCMP_OEQ)
>> +  VISITCOMP(NE, ICMP_NE , ICMP_NE , FCMP_UNE)
>> #undef VISITCOMP
>>
>>  Value *VisitBinAssign     (const BinaryOperator *E);
>>
>> Modified: cfe/trunk/lib/CodeGen/CGRTTI.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRTTI.cpp?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGRTTI.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CGRTTI.cpp Sat Dec 19 11:50:07 2009
>> @@ -115,7 +115,7 @@
>>    if (Hidden)
>>      GV->setVisibility(llvm::GlobalVariable::HiddenVisibility);
>>    return llvm::ConstantExpr::getBitCast(GV, Int8PtrTy);
>> -  };
>> +  }
>>
>>  /// - BuildFlags - Build a psABI __flags value for __vmi_class_type_info.
>>  llvm::Constant *BuildFlags(int f) {
>>
>> Modified: cfe/trunk/lib/CodeGen/ModuleBuilder.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/ModuleBuilder.cpp?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/ModuleBuilder.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/ModuleBuilder.cpp Sat Dec 19 11:50:07 2009
>> @@ -81,7 +81,7 @@
>>
>>      if (Builder)
>>        Builder->Release();
>> -    };
>> +    }
>>
>>    virtual void CompleteTentativeDefinition(VarDecl *D) {
>>      if (Diags.hasErrorOccurred())
>>
>> Modified: cfe/trunk/lib/Driver/Tools.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.h?rev=91779&r1=91778&r2=91779&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Driver/Tools.h (original)
>> +++ cfe/trunk/lib/Driver/Tools.h Sat Dec 19 11:50:07 2009
>> @@ -137,7 +137,7 @@
>>    }
>>
>>  public:
>> -    DarwinTool(const char *Name, const ToolChain &TC) : Tool(Name, TC)
>> {};
>> +    DarwinTool(const char *Name, const ToolChain &TC) : Tool(Name, TC) {}
>>  };
>>
>>  class VISIBILITY_HIDDEN CC1 : public DarwinTool  {
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>

More information about the cfe-commits mailing list