[cfe-commits] [PATCH] fix trailing separator in include path

Chris Lattner clattner at apple.com
Thu Dec 17 14:41:21 PST 2009


On Dec 17, 2009, at 1:08 PM, John Thompson wrote:

> The stat function on Windows doesn't like a path with a trailing separator like:  ../../
> This patch works around thant, but I don't know if it's the optimal solution.

Two issues.  First, that idiom for using endswith currently generates gross code.  We should fix this (http://llvm.org/bugs/show_bug.cgi?id=5822), but until then, please just check MappedPath.back() == '/' or something.  

Second, should this really go in InitHeaderSearch?  Would it make more sense to put in the getDirectory call itself?

-Chris



More information about the cfe-commits mailing list