[cfe-commits] r91016 - in /cfe/trunk: lib/Parse/ParseStmt.cpp lib/Parse/RAIIObjectsForParser.h test/Parser/cxx-stmt.cpp

[Chris Lattner]

On Dec 9, 2009, at 5:49 PM, Chris Lattner wrote:

>
> On Dec 9, 2009, at 5:07 PM, Douglas Gregor wrote:
>
>>
>> On Dec 9, 2009, at 4:38 PM, Chris Lattner wrote:
>>
>>> Author: lattner
>>> Date: Wed Dec  9 18:38:54 2009
>>> New Revision: 91016
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=91016&view=rev
>>> Log:
>>> fix PR5740: a colon is sacred when parsing case statement
>>> expressions!
>>
>> Looks good for PR5740, but did you audit the parser for other uses
>> of ':' that might be problematic? Labels, the conditional operator,
>> and bitfields come to mind as potential sources of problems.
>
> yes, I did (and added testcases!), except bitfields.  I should check
> those.

I think all the remaining issues are fixed,

-Chris