[cfe-commits] r90907 - /cfe/trunk/test/Preprocessor/dump_macros.c

[Daniel Dunbar]

On Tue, Dec 8, 2009 at 5:07 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Dec 8, 2009, at 4:04 PM, Daniel Dunbar wrote:
>
>> Author: ddunbar
>> Date: Tue Dec  8 18:04:46 2009
>> New Revision: 90907
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=90907&view=rev
>> Log:
>> Improve test portability; I can't figure out how to get the regexp library
>> to
>> match $ correctly with \r\n, unfortunately.
>
> Why is it getting \r\n?  It sounds like the real problem is that filecheck
> is opening the memory buffer as ascii instead of binary?

The output of clang has \r\n in it, which is correct, because it is
writing text output. I thought perhaps FileCheck could still normalize
\r\n in strict-whitespace mode, but if its only one test case...

 - Daniel

> -Chris
>
>>
>> Modified:
>>   cfe/trunk/test/Preprocessor/dump_macros.c
>>
>> Modified: cfe/trunk/test/Preprocessor/dump_macros.c
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/dump_macros.c?rev=90907&r1=90906&r2=90907&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/test/Preprocessor/dump_macros.c (original)
>> +++ cfe/trunk/test/Preprocessor/dump_macros.c Tue Dec  8 18:04:46 2009
>> @@ -1,11 +1,11 @@
>> // RUN: clang-cc -E -dM %s -o - | FileCheck %s -strict-whitespace
>>
>> // Space at end even without expansion tokens
>> -// CHECK: {{#define A[(]x[)] $}}
>> +// CHECK: #define A(x)
>> #define A(x)
>>
>> // Space before expansion list.
>> -// CHECK: {{#define B[(]x,y[)] x y$}}
>> +// CHECK: #define B(x,y) x y
>> #define B(x,y)x y
>>
>> // No space in argument list.
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>