[cfe-commits] r90661 - /cfe/trunk/lib/Sema/SemaCodeComplete.cpp

[Chris Lattner]

On Dec 5, 2009, at 1:09 AM, Douglas Gregor wrote:

> Author: dgregor
> Date: Sat Dec  5 03:08:56 2009
> New Revision: 90661
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=90661&view=rev
> Log:
> Improve the performance of code completion by 2.2x when completing for ordinary names with Cocoa.h included, by drastically improving the performance of our results sorting.

Wow, nice :)

> @@ -1088,7 +1129,7 @@
>                                                    : X.Pattern->getTypedText();
>         const char *YStr = (Y.Kind == Result::RK_Keyword)? Y.Keyword 
>                                                    : Y.Pattern->getTypedText();
> -        return strcmp(XStr, YStr) < 0;
> +        return strcasecmp(XStr, YStr) < 0;
>       }

I don't think that strcasecmp is portable to windows.  IIRC it is called stricmp there.  Can you use compare_lower on stringref instead?

-Chris