[cfe-commits] r90560 - /cfe/trunk/lib/Frontend/Backend.cpp

Daniel Dunbar daniel at zuster.org
Fri Dec 4 00:17:41 PST 2009


Author: ddunbar
Date: Fri Dec  4 02:17:40 2009
New Revision: 90560

URL: http://llvm.org/viewvc/llvm-project?rev=90560&view=rev
Log:
PR5684: Fix refacto, the backend consumer was copying the Diagnostic object,
which meant that hasErrorOccurred() checks to prevent codegen-on-invalid weren't
working.

Modified:
    cfe/trunk/lib/Frontend/Backend.cpp

Modified: cfe/trunk/lib/Frontend/Backend.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/Backend.cpp?rev=90560&r1=90559&r2=90560&view=diff

==============================================================================
--- cfe/trunk/lib/Frontend/Backend.cpp (original)
+++ cfe/trunk/lib/Frontend/Backend.cpp Fri Dec  4 02:17:40 2009
@@ -38,7 +38,7 @@
 
 namespace {
   class BackendConsumer : public ASTConsumer {
-    Diagnostic Diags;
+    Diagnostic &Diags;
     BackendAction Action;
     const CodeGenOptions &CodeGenOpts;
     const LangOptions &LangOpts;
@@ -66,8 +66,7 @@
 
     void CreatePasses();
 
-    /// AddEmitPasses - Add passes necessary to emit assembly or LLVM
-    /// IR.
+    /// AddEmitPasses - Add passes necessary to emit assembly or LLVM IR.
     ///
     /// \return True on success.
     bool AddEmitPasses();





More information about the cfe-commits mailing list