[cfe-commits] r90283 - in /cfe/trunk: lib/Sema/Sema.h lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaExprCXX.cpp test/CodeGenCXX/virtual-destructor-synthesis.cpp

Eli Friedman eli.friedman at gmail.com
Tue Dec 1 15:43:21 PST 2009


On Tue, Dec 1, 2009 at 3:18 PM, Fariborz Jahanian <fjahanian at apple.com> wrote:
> Author: fjahanian
> Date: Tue Dec  1 17:18:25 2009
> New Revision: 90283
>
> URL: http://llvm.org/viewvc/llvm-project?rev=90283&view=rev
> Log:
> Fix a code gen. crash synthesizing a destructor.
> Fixes pr5660.

This patch looks very wrong.  I think the real issue here is something
similar to PR5557: Sema doesn't know whether the vtable is created,
and therefore doesn't do the stuff that MarkDeclarationReferenced is
supposed to do for virtual functions.

-Eli




More information about the cfe-commits mailing list