[cfe-commits] r89822 - /cfe/trunk/include/clang/AST/Redeclarable.h

[Douglas Gregor]

On Nov 25, 2009, at 1:12 AM, John McCall wrote:

> Sebastian Redl wrote:
>> 
>> On Wed, 25 Nov 2009 00:38:36 -0000, Douglas Gregor <dgregor at apple.com>
>> wrote:
>>   
>>> Author: dgregor
>>> Date: Tue Nov 24 18:38:36 2009
>>> New Revision: 89822
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=89822&view=rev
>>> Log:
>>> Qualify the name of the llvm::cast template. I am somewhat amazed that
>>>     
>> GCC
>>   
>>> parsed this
>>>     
>> 
>> Doesn't some AST header import cast & friends into the Clang namespace?
>> It's likely that this header was always included before Redeclarable.h.
>>   
> 
> It's Type.h, which is included pretty much universally.
> 
> using llvm::isa;
> using llvm::cast;
> using llvm::cast_or_null;
> using llvm::dyn_cast;
> using llvm::dyn_cast_or_null;


... but Redeclarable.h doesn't include Type.h. I checked, and there aren't any using declarations or directives in scope that would make llvm::cast visible in namespace clang in Redeclarable.h.

	- Doug
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20091125/6c0b8b98/attachment.html>