[cfe-commits] [Review] rolling out ASTContext::getTypeSizeInBytes()
John McCall
rjmccall at apple.com
Tue Nov 24 14:04:07 PST 2009
Eli Friedman wrote:
> On Tue, Nov 24, 2009 at 1:25 PM, John McCall <rjmccall at apple.com> wrote:
>
>> This implicitly assumes that arithmetic on void* is in 1-byte chunks.
>>
>
> Arithmetic on void* is in sizeof(char) chunks, which are "1-byte" by definition.
>
Ah, right, that camp. I'm sorry, I didn't read closely enough;
everything looks fine.
I assume a patch to switch codegen's hardcoded uses of i8 to the
appropriate byte pointer is forthcoming?
John.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20091124/ecaf081c/attachment.html>
More information about the cfe-commits
mailing list