[cfe-commits] [Review] C++0x Attributes Patch

Sebastian Redl sebastian.redl at getdesigned.at
Tue Nov 17 14:10:57 PST 2009


Sean Hunt wrote:
> This patch is the newest version of my attributes patch, with
> questions/comments addressed. Reviews would be appreciated so that I
> can commit. Thanks.
Looks excellent. One minor thing: check that the first sentence in
Doxygen comments ends with a period. Javadoc terminates the short
description at this period, and I think Doxygen does the same if no
explicit brief comment is supplied.
One more important thing: this patch doesn't seem to contain test cases.

Sebastian



More information about the cfe-commits mailing list