[cfe-commits] r88856 - /cfe/trunk/test/CodeGenCXX/rtti.cpp

[Mike Stump]

On Nov 16, 2009, at 10:14 AM, Daniel Dunbar wrote:
> On Sun, Nov 15, 2009 at 10:57 AM, Mike Stump <mrs at apple.com> wrote:
>> Author: mrs
>> Date: Sun Nov 15 11:57:00 2009
>> New Revision: 88856
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=88856&view=rev
>> Log:
>> Fix linux buildbots.
>
>> +// FIXME: The above doesn't work in some environments.  What's the  
>> best way to fix this?
>> +// XFAIL: *
>
> Note that this doesn't make sense, "XFAIL: *" means that this test
> will be expected to fail everwhere. Given that the buildbots aren't
> complaining, it means this test *is* failing everywhere.
>
> If you wanted to spell "xfail on linux", it would look something  
> like this:
>  XFAIL: linux
> The XFAIL arguments are comma separated, and each is checked to see if
> it is present in the target triple -- if so it is a match and the test
> is regarded as XFAIL.

The problem is that I need to include the typeinfo header.  One way to  
do this, would be to just dummy one up for testing, and include it.   
I'll propose changing clang's lit.cfg file to include .ii files, and  
then I can defeat the typeinfo header check by using a .ii file to  
test with.  Sound good?