[cfe-commits] r88900 - /cfe/trunk/test/CodeGenCXX/delete-two-arg.cpp

[Douglas Gregor]

On Nov 16, 2009, at 10:04 AM, Mike Stump wrote:

> On Nov 16, 2009, at 9:36 AM, Douglas Gregor wrote:
>>> -// RUN: clang-cc %s -o - -emit-llvm -verify | FileCheck %s
>>> +// RUN: clang-cc -triple i686-pc-linue-gnu %s -o - -emit-llvm - 
>>> verify | FileCheck %s
>>
>> Typo "linue" in this triple...
>
> That's what I get for copying the triplet from another case:
>
> $ grep i686-pc-linue-gnu *.cpp
> delete-two-arg.cpp:// RUN: clang-cc -triple i686-pc-linue-gnu %s -o  
> - -emit-llvm -verify | FileCheck %s
> explicit-instantiation.cpp:// RUN: clang-cc -emit-llvm -triple i686- 
> pc-linue-gnu -o %t %s
>
> to make sure it is right, what are the odds?  Hum:
>
> r81562 | dgregor | 2009-09-11 13:15:17 -0700 (Fri, 11 Sep 2009) | 8  
> lines
>
> Tweak the semantics of FunctionDecl::isOutOfLine to consider an
> instantiation of a member function template or member function of a
> class template to be out-of-line if the definition of that function
> template or member function was defined out-of-line. This ensures that
> we get the correct linkage for explicit instantiations of out-of-line
> definitions.
>
> So, I guess, the next question is, any objection to fixing them both?

No objection.

	- Doug