[cfe-commits] r83426 - in /cfe/trunk: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGCXXClass.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/virtual-base-cast.cpp

[Anders Carlsson]

Mike,

do you have a smaller test case that shows this? If so I can try to get it working.

Anders

On Nov 13, 2009, at 10:31 AM, Mike Stump wrote:

> On Oct 6, 2009, at 3:43 PM, Anders Carlsson wrote:
>> Author: andersca
>> Date: Tue Oct  6 17:43:30 2009
>> New Revision: 83426
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=83426&view=rev
>> Log:
>> Change GetAddressCXXOfBaseClass to use CXXBasePaths for calculating base class offsets. Fix the code to handle virtual bases as well.
> 
> :-(  Doesn't seem to work so well.  virt.cc from the testsuite causes this to see a virtual base, but then pass it to the non-virtual builder, which asserts when it finds a virtual base in the path.  :-(  Eli turned off virt.cc, but I have to have that testcase on, so...  I'm going to turn off the virtual code here, so I can turn virt.cc back on.
> 
> I really hate to do this.  I believe he should have turned off the conversion code itself, if it wasn't working, rather than a working testcase under active development.
> 
> This is just a heads up, so you know what's up.