[cfe-commits] r86500 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGCXX.cpp lib/Sema/Sema.h lib/Sema/SemaDeclCXX.cpp test/CXX/temp/temp.spec/temp.expl.spec/p4.cpp test/CodeGenCXX/virt.cpp test/SemaCXX/constructor-initia

[Eli Friedman]

On Thu, Nov 12, 2009 at 7:05 PM, Mike Stump <mrs at apple.com> wrote:
> On Nov 8, 2009, at 5:05 PM, Eli Friedman wrote:
>>
>> Author: efriedma
>> Date: Sun Nov  8 19:05:47 2009
>> New Revision: 86500
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=86500&view=rev
>> Log:
>> Unify the codepaths used to verify base and member initializers for
>> explicitly
>> and implicitly defined constructors.
>
>> --- cfe/trunk/test/CodeGenCXX/virt.cpp (original)
>> +++ cfe/trunk/test/CodeGenCXX/virt.cpp Sun Nov  8 19:05:47 2009
>> @@ -4,6 +4,7 @@
>> // RUN: clang-cc -triple x86_64-apple-darwin -std=c++0x -emit-llvm %s -o
>> %t-64.ll
>> // RUN: FileCheck -check-prefix LPLL64 --input-file=%t-64.ll %s
>>
>> +// XFAIL: *
>
> That's kinda buried way down in there...   Imagine my surprise when I notice
> that I have zero coverage for the work I'm currently doing...  You have any
> state on this to share?

Sorry, perhaps I should have noted that in the commit.  Constructors
for virtual bases aren't working.  That said, they weren't working
before anyway for explicitly declared constructors (see the FIXME), so
I figured the whole thing was a work in progress.  As far as I can
tell, GetCXXBaseClassOffset is broken for virtual bases with a virtual
base, and I'm not sure how to go about fixing it.

-Eli